Convert PHP MySQL Code to MySQLi -


i use code below login system on site. lot of programmers on other sites said code not safe in way, login system created huge. can't rebuild all, takes ages beginner programmer in php.

<?php $destroy = false;  require('connect.php'); session_start();  if (isset($_post['username']) , isset($_post['password'])){  $username = $_post['username']; $password = $_post['password'];  $query = "select * `user` username='$username' , password='$password'";  $result = mysql_query($query) or die(mysql_error()); $count = mysql_num_rows($result);  if ($count == 1){ $_session['username'] = $username; }else{ header("location: index.php?login=invalid"); } }  if (isset($_session['username'])){ $username = $_session['username']; include("inc/dashboard.inc.php"); } else {   if(isset($msg) & !empty($msg)){     echo $msg; }  if(isset($_get["login"]) && $_get["login"] === "invalid") {     echo "<div class='redtxt'>that account doesn't exist.</div>"; } ?> <form action="" method="post"> <p><label>username:</label><br /><input id="username" type="text" name="username" /></p> <p><label>password:</label><br /><input id="password" type="password" name="password"  /></p> <input type="submit" name="submit" value="sign in" /> </form> <?php } ?>

you should convert functions mysqli (see previous answer) , besides need use prepared statements make whole lot safer: http://mattbango.com/notebook/code/prepared-statements-in-php-and-mysqli/

--edit-- , pointed out others should hash password value (not md5 please)


Comments

Post a Comment

Popular posts from this blog

c++ - Difference between pre and post decrement in recursive function argument -

i have following sample code used pre-decrement void function(int c) { if(c == 0) { return; } else { cout << "dp" << c << endl; function(--c); cout << c << endl; return; } } this function give output input 4 : dp3 dp2 dp1 dp0 0 1 2 3 but when use post decrement void function(int c) { if(c == 0) { return; } else { cout << "dp" << c << endl; function(c--); cout << c << endl; return; } } output goes in infinite loop dp4 can explain me in detail why happens ? this happens because function(c--) called same value of c , when finishes c decremented. recursively called, hence called same value no chance of return , hit stack overflow error. assume this, int x = 1, y = 0; y = x++ result y == 1 , x == 2. if y = ++x , bot x , y 2.
Read more

php - Nothing but 'run(); ' when browsing to my local project, how do I fix this? -

i added new project. made mistake in projectname.conf file in sites-available apache2, led me reinstalling apache2. after reinstalling , re-enabling projects on every page of every project .. <body> run(); </body> .. i've run composer update, restarted service, restarted pc, checked config files, tried disabling new project. there nothing in error log, , access.log: 127.0.0.1 - - [15/may/2015:01:40:47 +0200] "get / http/1.1" 304 181 "-" "mozilla/5.0 (x11; ubuntu; linux x86_64; rv:38.0) gecko/20100101 firefox/38.0" maybe i'm forgetting apache2 reinstall? don't think did different last time installed it. looks haven't setup php correctly. take @ this great guide , maybe you're forgetting link php config apache2.
Read more

php - How can I echo out this array? -

i don't know how go grabbing data in variable , put foreach loop. class tree{ private $info = array( array('name'=>'jim','state'=>'nu','company'=>'nu','phone'=>array('cell'=>'5615111111','office'=>'5611111111'),'email'=>array('primary'=>'exs@example.com','ex@there.com')), array('name'=>'joe smith','city'=>'phoenix','phone'=>'4805551111','email'=>'jsmith@some_email.com'), array('name'=>'john doe','city'=>'chandler','company'=>'doe co.','email'=>array('jdoe@gmail.com','personal'=>'email@email.com'),'phone'=>'6025550002') ); } if you're inside of class, can access private variable using $this->variablename . example, i...
Read more