Call a PHP function inside of a while loop -


i have function gets particular set of users table particular where condition meet.

i need send each of them message.

so, used function send message. , called function inside following while loop

while($user= mysqli_fetch_assoc($users_set)){    send_message($user['email']); }

so, problem is, function called 1 time. (only last value of loop)

how fix problem , make function called each value of loop...

this full code...

$query = "select * "; $query .= "from user "; $query .= "where confirmed = 0";  $user_set = mysqli_query($db_conx, $query); confirm_query($user_set);  while($user = mysqli_fetch_assoc($user_set)){    send_message($user['email']); }

here send message function.... 

function send_message($email){ global $db_conx;  $invitee_user = get_user_by_email($email);  $query5 = "insert notification("; $query5 .= "description, user_id"; $query5 .= ") values("; $query5 .= "'you have been confirmed'"; $query5 .= ", {$invitee_user['id']}"; $query5 .= ")";  $result5 = mysqli_query($db_conx, $query5);  if($result5){     //$_session["message"] = "notification sent". \mysqli_error($db_conx);     return "ok"; }else{     //$_session["message"] = "failed send notification". mysqli_error($db_conx); }

}

here code confirm_query() 

function confirm_query($result_set){ if(!$result_set){    die("fatal error occured : database query failed <a href=\"error-report.php\">report error</a>");  }

}

i boil down 1 query , rid of looping stuff

insert notification (description, user_id) select 'you have been confirmed', user_id user confirmed = 0

your current logic convoluted.

you query user table user email field, pass email parameter function turn around , (i presume) user id based on email (when had information initial query), make insert.

this means every record return first query, need 2 queries insert notification table. if had 100 results end doing total of @ least 201 queries complete insertions.

using approach make 1 query regardless of how many rows affected.

one takeaway should that, anytime see trying sort of nested querying, should recognize anti-pattern (a coding pattern not want typically use). there better approach can taken if rethink how writing queries.


Comments

Post a Comment

Popular posts from this blog

c++ - Difference between pre and post decrement in recursive function argument -

i have following sample code used pre-decrement void function(int c) { if(c == 0) { return; } else { cout << "dp" << c << endl; function(--c); cout << c << endl; return; } } this function give output input 4 : dp3 dp2 dp1 dp0 0 1 2 3 but when use post decrement void function(int c) { if(c == 0) { return; } else { cout << "dp" << c << endl; function(c--); cout << c << endl; return; } } output goes in infinite loop dp4 can explain me in detail why happens ? this happens because function(c--) called same value of c , when finishes c decremented. recursively called, hence called same value no chance of return , hit stack overflow error. assume this, int x = 1, y = 0; y = x++ result y == 1 , x == 2. if y = ++x , bot x , y 2.
Read more

php - Nothing but 'run(); ' when browsing to my local project, how do I fix this? -

i added new project. made mistake in projectname.conf file in sites-available apache2, led me reinstalling apache2. after reinstalling , re-enabling projects on every page of every project .. <body> run(); </body> .. i've run composer update, restarted service, restarted pc, checked config files, tried disabling new project. there nothing in error log, , access.log: 127.0.0.1 - - [15/may/2015:01:40:47 +0200] "get / http/1.1" 304 181 "-" "mozilla/5.0 (x11; ubuntu; linux x86_64; rv:38.0) gecko/20100101 firefox/38.0" maybe i'm forgetting apache2 reinstall? don't think did different last time installed it. looks haven't setup php correctly. take @ this great guide , maybe you're forgetting link php config apache2.
Read more

php - How can I echo out this array? -

i don't know how go grabbing data in variable , put foreach loop. class tree{ private $info = array( array('name'=>'jim','state'=>'nu','company'=>'nu','phone'=>array('cell'=>'5615111111','office'=>'5611111111'),'email'=>array('primary'=>'exs@example.com','ex@there.com')), array('name'=>'joe smith','city'=>'phoenix','phone'=>'4805551111','email'=>'jsmith@some_email.com'), array('name'=>'john doe','city'=>'chandler','company'=>'doe co.','email'=>array('jdoe@gmail.com','personal'=>'email@email.com'),'phone'=>'6025550002') ); } if you're inside of class, can access private variable using $this->variablename . example, i...
Read more